Run sync server in a fiber #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 1.x.x #8 +/- ##
=========================================
Coverage 80.00% 80.00%
Complexity 12 12
=========================================
Files 5 5
Lines 40 40
=========================================
Hits 32 32
Misses 8 8
Continue to review full report at Codecov.
|
xserrat
approved these changes
Dec 17, 2021
| @@ -19,6 +19,7 @@ | |||
| "nyholm/psr7": "^1.4", | |||
| "nyholm/psr7-server": "^1.0", | |||
| "psr/http-server-middleware": "^1.0", | |||
| "react/async": "@dev", | |||
There was a problem hiding this comment.
Do we need the dev version of this package?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Running await makes the current sync server fail with a segmentation fault because the fiber isn't already started.
Motivation and context
It fixes the described situation and adds real support to use async APIs inside the sync server.
How has this been tested?
Covered by unit tests and tested manually
Screenshots (if appropriate)
Types of changes
What types of changes does your code introduce? Put an
xin all the boxes that apply:Checklist: